Add robolectric basic sample by fbertault · Pull Request #146 · android/testing-samples

fbertault · 2017-09-25T22:09:39Z

Add example tests using robolectric. Copied the espresso BasicSample as is, with some string substitutions.

jongerrish · 2017-09-25T22:34:32Z

+This project uses the Gradle build system. You don't need an IDE to build and execute it but Android Studio is recommended.
+
+1. Download the project code, preferably using `git clone`.
+1. Open the Android SDK Manager (*Tools* Menu | *Android*) and make sure you have installed the *Android Support Repository* under *Extras*. (For more Information click [here](http://developer.android.com/tools/testing-support-library/index.html#setup))


This step is not necessary for Robolectric... it might not be necessary for instrumentation tests now since we're in gMaven @slinzner ?

jongerrish · 2017-09-25T22:39:14Z

+    compileSdkVersion 26
+    buildToolsVersion rootProject.buildToolsVersion
+    defaultConfig {
+        applicationId "com.example.android.testing.robolectric.BasicSample"


I don't think application id's usually have capital letters in do they? Is this the pattern in the other samples?

Yes, it matches the other examples (it matches the package name which is uppercase).

jongerrish · 2017-09-25T22:44:51Z

+    @Test
+    public void createActivityFromIntent() {
+        Intent intent = new Intent(RuntimeEnvironment.application, MainActivity.class);
+        Robolectric.buildActivity(MainActivity.class, intent).setup().get();


This isn't really asserting anything, for this to be valuable you really want to make some assertions, like, have the activity render some data in the test fields that you specified in the intent for example.

jongerrish · 2017-09-25T22:48:28Z

+
+    @Test
+    public void pauseResumeActivity() {
+        ActivityController<MainActivity> controller = Robolectric.buildActivity(MainActivity.class);


I don't really like this kind of test as it is not demonstrating any behaviour.

jongerrish · 2017-09-25T22:48:54Z

+    public void setUp() {
+        Intent intent = new Intent(RuntimeEnvironment.application, ShowTextActivity.class);
+        intent.putExtra(ShowTextActivity.KEY_EXTRA_MESSAGE, MESSAGE);
+        activity = Robolectric.buildActivity(ShowTextActivity.class, intent).setup().get();


Robolectric.setupActivity()

I don't think it works with an intent does it?

slinzner

Overall LGTM. Please add licenses to all the files and make sure you use the correct date (2017) on the license.

slinzner · 2017-09-26T16:40:11Z

@@ -0,0 +1,69 @@
+/*
+ * Copyright 2015, The Android Open Source Project


slinzner · 2017-09-26T16:41:36Z

@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+  ~ Copyright (C) 2015 The Android Open Source Project


slinzner · 2017-09-26T16:41:53Z

+  -->
+<resources>
+    <style name="AppTheme" parent="android:Theme.Holo.Light"/>
+</resources>


add newline

slinzner · 2017-09-26T16:42:35Z

@@ -0,0 +1,37 @@
+package com.example.android.testing.robolectric.BasicSample;


license missing

slinzner · 2017-09-26T16:43:20Z

+ext {
+    buildToolsVersion = "25.0.0"
+    supportLibVersion = "25.4.0"
+    runnerVersion = "1.0.0"


slinzner · 2017-09-26T16:44:08Z

@@ -1,5 +1,6 @@
 integration/ServiceTestRuleSample
 runner/AndroidJunitRunnerSample
+ui/robolectric/BasicSample


this should be under unit/ not ui/

Moved to unit/BasicRobolectricSample.

slinzner · 2017-10-03T00:28:44Z

+    lintOptions {
+        abortOnError false
+    }
+    testOptions {


Please add a comment to indicate that this is required in order for Robolectric to work

slinzner · 2017-10-03T00:31:15Z

+}
+
+ext {
+    buildToolsVersion = "25.0.0"


Update this to the latest version, which I guess should be 26.0.0

slinzner

LGTM, thanks for the changes. Please run the ./test_all.sh script before submitting to make sure everything still works.

fbertault · 2017-10-06T15:51:52Z

Checked ./test_all.sh : ALL TESTS PASS

mrk-han · 2018-11-14T05:09:16Z

Curious if all of the tests passed on Oct 6, 2017, why was this never merged in?

fbertault added 5 commits September 23, 2017 17:16

Add robolectric basic sample

61e7e45

Add robolectric basic sample

9fb578a

Removed unused deps.

9a7c29b

Fix robolectricVersion

a2d5df5

Gradle changes, using android 3.0+ config.

e6921ad

jongerrish suggested changes Sep 25, 2017

View reviewed changes

Addressed comments.

0859b12

googlebot added the cla: yes label Sep 26, 2017

jongerrish requested review from nkoroste and slinzner September 26, 2017 16:04

jongerrish approved these changes Oct 2, 2017

View reviewed changes

slinzner suggested changes Oct 2, 2017

View reviewed changes

slinzner requested a review from JoseAlcerreca October 2, 2017 18:56

nkoroste approved these changes Oct 2, 2017

View reviewed changes

fbertault added 3 commits October 2, 2017 16:15

Moved to unit/BasicRobolectricSample + addressed comments.

4518de9

Moved to unit/BasicRobolectricSample + addressed comments.

2d8dda1

Moved to unit/BasicRobolectricSample + addressed comments.

93aa0cd

slinzner suggested changes Oct 3, 2017

View reviewed changes

Addressed comments, updated versions and launcher icon.

9f9f26b

slinzner approved these changes Oct 3, 2017

View reviewed changes

codingjeremy changed the base branch from master to main September 29, 2020 17:58

		@@ -0,0 +1,69 @@
		/*
		* Copyright 2015, The Android Open Source Project

		@@ -0,0 +1,37 @@
		package com.example.android.testing.robolectric.BasicSample;

Conversation

fbertault commented Sep 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

slinzner left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

slinzner left a comment

Choose a reason for hiding this comment

Uh oh!

fbertault commented Oct 6, 2017

Uh oh!

mrk-han commented Nov 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

slinzner left a comment •

edited

Loading